Open gaoqiangz opened 1 year ago
Hey. Thanks for the PR! Unfortunately, since this is an Eclipse project, I won't be able to merge it unless you sign an Eclipse ECA. See here: https://www.eclipse.org/legal/ECA.php
But also...
Please describe the specific problem which you are attempting to fix. On which platform(s).
Also:
I know the build still needs work, but so far, every attempt to update it has broken at least on of these platforms.
Sorry.....I have been busy recently.I haven't tested on Linux/MacOS yet.
This PR solves the issue of openssl linking by delegating to openssl-sys
to avoid static link error (see: https://github.com/eclipse/paho.mqtt.rust/issues/158, https://github.com/eclipse/paho.mqtt.rust/issues/134).
I have tested on Windows MSVC it works fine.
Once I have time, I will test it on other platforms, maybe you can help me? :-)
Sorry for the code formating... Here is the change list:
lib.rs
We should explicit import
openssl_sys
crate to makebuild.rs
works.build.rs
Delete these lines. https://github.com/eclipse/paho.mqtt.rust/blob/be43ef8f2ec25bda2a37850c0ef5227971049e38/paho-mqtt-sys/build.rs#L309-L337
Change
openssl_root_dir
https://github.com/eclipse/paho.mqtt.rust/blob/be43ef8f2ec25bda2a37850c0ef5227971049e38/paho-mqtt-sys/build.rs#L242-L248to
See also https://github.com/sfackler/rust-openssl/blob/979f982e067bd310a7aff1cfa5f711ed7bcf0d95/openssl-sys/build/main.rs#L49.