search

eclipse / poosl

Poosl project.
Eclipse Public License 2.0
8 stars 7 forks source link

Adding a channel resets the previous layout of a channel #37

Closed arnauddieumegard closed 1 year ago

arnauddieumegard commented 2 years ago

Lets assume the following model: image

If I create a new channel between Production.Control and folder.in then the layout becomes: image

One may want the black square to stay at its previous location.

wpiers commented 1 year ago

"in" and "Control" ports are both already connected to several ports, thus have a black square each (a ChannelCluster). When you connect those two, the two channel clusters are merged. If the channel is created started from "in", the "in" channel cluster is kept, the other is deleted and its edges are reconnected to the "in" cluster. And the other way around.

So basically the square does not move, it is merged with another. The relayout of the channels previously connected to the deleted ChannelCluster give a wrong impression of what happens.

I will close this issue as the channel merging worked as intended but note that the layout of channel is already the subject of another issue, #29, so there are leads to improve the UX on this subject.