test: update tests to make CI green again

eclipse / repairnator

Software development bots for Github. Join the bot revolution! :star2::robot::star2::revolving_hearts:

MIT License

384 stars 83 forks source link

test: update tests to make CI green again #1221

Closed javierron closed 3 years ago

javierron commented 3 years ago

Updated GithubScanner tests, as a change on the GitHub API broke the API library we use and later was fixed.
Specified target endpoint on testRepositoryWithoutCheckstyleIsNotInteresting() to avoid flakiness
Changed target build in testPipelineGitRepositoryAndCommitIdWithFailure() to avoid flakiness #1176

javierron commented 3 years ago

@monperrus fixed two of the flaky/broken tests, but the GithubScanner will be broken until: (1) the Github API library is updated or (2) change library / implement our own request. WDYT?

monperrus commented 3 years ago

Per our discussion, option 2 with a simple HTTP request sounds a good solution.

javierron commented 3 years ago

The Github API library released a new version fixing the problem today. It only required a small update too on our side.

Ready to merge as soon as the tests are green.

@monperrus

monperrus commented 3 years ago

That's super! Thanks @javierron