search

eclipse / swtchart

Eclipse Public License 2.0
48 stars 41 forks source link

Contribute PieChart from Linux Tools project #114

Closed akurtakov closed 4 years ago

akurtakov commented 4 years ago

In Linux Tools project we have extension to swtchart to provide PieChart. Is swtchart project interested in such contribution? If yes I would appreciate some guidance and help to do that. Code is at https://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/tree/profiling/org.eclipse.linuxtools.dataviewers.piechart/src/org/eclipse/linuxtools/dataviewers/piechart

eselmeister commented 4 years ago

That would be great. We already have packages in the bundle "org.eclipse.swtchart.extensions" for bar, line and scatter charts:

org.eclipse.swtchart.extensions.barcharts org.eclipse.swtchart.extensions.linecharts org.eclipse.swtchart.extensions.scattercharts

So, please create a new bundle called:

org.eclipse.swtchart.extensions.piecharts

and place the code in the bundle. Additionally, an example part how to use the pie chart could be created here:

org.eclipse.swtchart.extensions.examples.parts

I'll review and merge the code, as soon as I get a PR. As soon as the code has been merged, I would take care to extend it to support scrolling, the settings and pop-up menu support and so on.

Best, Philip

Am 11.02.20 um 14:31 schrieb Alexander Kurtakov:

In Linux Tools project we have extension to swtchart to provide PieChart. Is swtchart project interested in such contribution? If yes I would appreciate some guidance and help to do that. Code is at https://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/tree/profiling/org.eclipse.linuxtools.dataviewers.piechart/src/org/eclipse/linuxtools/dataviewers/piechart

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eclipse/swtchart/issues/114?email_source=notifications&email_token=AAFHUT5CTQSYSV5OMLULWYTRCMDKDA5CNFSM4KTH7GI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IMVWTIQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHUT25PU2ULSO2KP4PYYDRCMDKDANCNFSM4KTH7GIQ.

-- 

OpenChrom - the open source alternative for chromatography / mass spectrometry
Dr. Philip Wenig » Founder » philip.wenig@openchrom.net » http://www.openchrom.net
laeubi commented 4 years ago

Does scrolling really makes sense for a pie chart?

eselmeister commented 4 years ago

No, scrolling doesn't make sense for a pie chart. The scrolling support can be deactivated by a respective pie chart class via the settings.

Am 01.03.20 um 11:54 schrieb Christoph Läubrich:

Does scrolling really makes sense for a pie chart?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/eclipse/swtchart/issues/114?email_source=notifications&email_token=AAFHUT5752DW2YYZORO7TMLRFI5GPA5CNFSM4KTH7GI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENM3VNY#issuecomment-593083063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHUT2A4XWZQHOCEWDYUP3RFI5GPANCNFSM4KTH7GIQ.

-- 

OpenChrom - the open source alternative for chromatography / mass spectrometry
Dr. Philip Wenig » Founder » philip.wenig@openchrom.net » http://www.openchrom.net
akurtakov commented 4 years ago

On Mon, Mar 9, 2020 at 3:37 PM Himanshu Balasamanta < notifications@github.com> wrote:

In Linux Tools project we have extension to swtchart to provide PieChart. Is swtchart project interested in such contribution? If yes I would appreciate some guidance and help to do that. Code is at https://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/tree/profiling/org.eclipse.linuxtools.dataviewers.piechart/src/org/eclipse/linuxtools/dataviewers/piechart

Hello Alexander, I am intrested in proposing this project as my GSoC project for eclipse. I would like to take permission from you before proceeding..

That is fine by me. Please state your intend on the github issue so we can see what do the swtchart devs think about such GSoC.

Thanks in advanced

Himanshu

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eclipse/swtchart/issues/114?email_source=notifications&email_token=AAEMKRE77XOXEDBFLDUATU3RGTWJ5A5CNFSM4KTH7GI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHEZ7I#issuecomment-596528381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEMKRA3TN6OVKENCVTY4WDRGTWJ5ANCNFSM4KTH7GIQ .

eselmeister commented 4 years ago

Merge by @Himanshu-Balasamanta

eselmeister commented 4 years ago

https://github.com/eclipse/swtchart/pull/138 Improvements will be applied, based on the linked PR.