eclipse / swtchart

Eclipse Public License 2.0
47 stars 41 forks source link

Internal Package - CircularSeries #202

Closed eselmeister closed 4 years ago

eselmeister commented 4 years ago

Instead of using CircularSeries, the interface ICircularSeries should be better used as access to internal packages from outside bundles is discouraged.

CircularSeries multiLevelPie = (CircularSeries)chart.getSeriesSet().createSeries(SeriesType.PIE, "countries");

should be better:

ICircularSeries multiLevelPie = (ICircularSeries)chart.getSeriesSet().createSeries(SeriesType.PIE, "countries");

Or in "AbstractExtendedChart":

((CircularSeries)series).setDataModel(model);

the interface should be used instead:

((ICircularSeries)series).setDataModel(model);

eselmeister commented 4 years ago

@Himanshu-Balasamanta Please have a look at hit. But it's just a minor issue.