search

eclipse / swtchart

Eclipse Public License 2.0
44 stars 41 forks source link

Allow tick labels to display even with lossy formatters #215

Closed MatthewKhouzam closed 4 years ago

MatthewKhouzam commented 4 years ago

Handle significant digits, assume that if a value is within 1% (arbitrary)

Fixes https://github.com/eclipse/swtchart/issues/214

Signed-off-by: Matthew Khouzam matthew.khouzam@ericsson.com

MatthewKhouzam commented 4 years ago

May not be required, I need to verify the comments on secondary axes.

eselmeister commented 4 years ago

@MatthewKhouzam Sure, let me know if you need more help to get your code up and running.

MatthewKhouzam commented 4 years ago

@eselmeister I have sidestepped the issue with this: https://git.eclipse.org/r/c/tracecompass/org.eclipse.tracecompass/+/167207, I think this is still a real issue with swtchart. It is basically working since the assumption of everything being base-10 and then trailing 0s don't matter. If you think this kind of "fuzzy check" is useful, I can continue in spare time, but it is no longer urgent for my work. :)

eselmeister commented 4 years ago

@MatthewKhouzam Your fix looks good. I have merged it into the "develop" branch: https://github.com/eclipse/swtchart/commit/2d0865e339b85c6006a10a22f119b770b263302e

I have not merged it into the release 0.12.0, as it would require to publish a service release.

GSoC ends in August. Thus, a new release of SWTChart is planned for beginning of September. This is hopefully in time, so that SWTChart is able to join the Eclipse release train and TraceCompass probably could switch to the next version.