eclipse / swtchart

Eclipse Public License 2.0
48 stars 41 forks source link

Modify/Delete Mappings #235

Closed eselmeister closed 3 years ago

eselmeister commented 4 years ago

It would be nice to edit the mappings, e.g.

Bildschirmfoto von 2020-11-21 08-39-01

Tanmay2510 commented 3 years ago

@eselmeister Sir, do the buttons(DELETE,Export,Reset,Import) need to be put inside the setting mappings UI beside the Ok and Exit button or it should be aligned with extended legend buttons?

eselmeister commented 3 years ago

Hi Tanmay,

please place them inside the "Setting Mappings" dialog right aligned on top of the list "ID, Description". Use the code snippet as a hint:

Composite composite = new Composite(parent, SWT.NONE); GridData gridData = new GridData(GridData.FILL_HORIZONTAL); gridData.horizontalAlignment = SWT.END; composite.setLayoutData(gridData); composite.setLayout(new GridLayout(2, false)); ... create Button ... create Button

Best, Philip

Am 01.03.21 um 18:17 schrieb Tanmay Raikwar:

Do the buttons(DELETE,Export,Reset,Import) needs to be put inside the setting mappings UI beside the Ok and Exit button or it should be aligned with extended legend buttons?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/eclipse/swtchart/issues/235#issuecomment-788120497, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHUT2XIPJGTGBQ3PS62XDTBPD2JANCNFSM4T5UAPZA.

--

OpenChrom - the open source alternative for chromatography / mass spectrometry
Dr. Philip Wenig » Founder » philip.wenig@openchrom.net » http://www.openchrom.net
Tanmay2510 commented 3 years ago

@eselmeister Sir, I am stuck. I am unable to create any changes/or create a button inside the "Setting Mappings" dialog. And even if I create a button it gets placed in extended legend. Could you please help me?

eselmeister commented 3 years ago

Tanmay,

try harder to find a solution :-).

Best, Philip

Am 06.03.21 um 09:42 schrieb Tanmay Raikwar:

@eselmeister https://github.com/eselmeister Sir, I am stuck. I am unable to create any changes/or create a button inside the "Setting Mappings" dialog. And even if I create a button it gets placed in extended legend. Could you please help me?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse/swtchart/issues/235#issuecomment-791896886, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHUT3EHNCZ7CYYO3CDZZ3TCHTHJANCNFSM4T5UAPZA.

--

OpenChrom - the open source alternative for chromatography / mass spectrometry
Dr. Philip Wenig » Founder » philip.wenig@openchrom.net » http://www.openchrom.net
Tanmay2510 commented 3 years ago

Tanmay, try harder to find a solution :-). Best, Philip Am 06.03.21 um 09:42 schrieb Tanmay Raikwar: @eselmeister https://github.com/eselmeister Sir, I am stuck. I am unable to create any changes/or create a button inside the "Setting Mappings" dialog. And even if I create a button it gets placed in extended legend. Could you please help me? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHUT3EHNCZ7CYYO3CDZZ3TCHTHJANCNFSM4T5UAPZA. -- ~~~~~~ OpenChrom - the open source alternative for chromatography / mass spectrometry Dr. Philip Wenig » Founder » philip.wenig@openchrom.net » http://www.openchrom.net ~~~~~~ Update: Successfully created a button inside the Mapping Setting dialog. ButtonsEclipse

eselmeister commented 3 years ago

A refresh is required when the mapped settings are deleted. Importing settings automatically tries to match the settings.

Bildschirmfoto von 2021-05-22 09-56-27

Bildschirmfoto von 2021-05-22 09-57-12

Bildschirmfoto von 2021-05-22 09-57-24

Please note, the settings ids might change in the future. Hence, the settings export/import is intended to be used in a short period of time.

Bildschirmfoto von 2021-05-22 09-57-46

Bildschirmfoto von 2021-05-22 09-58-15

Bildschirmfoto von 2021-05-22 09-58-20

eselmeister commented 3 years ago

I have an idea how to enable the reset functionality without hassles.

eselmeister commented 3 years ago

This is a complex issue :-). I have recognized, that the export dialog changes the settings too. The export shall only change the series settings temporarily.

eselmeister commented 3 years ago

The mappings dialog has been modified. It's possible to reset selected and all mappings. It will replace the changes by the defaults. Remove all clears the mappings as well as the defaults. The next time, a change is made to the settings, a new default is created.

Bildschirmfoto von 2021-05-25 07-03-48

Bildschirmfoto von 2021-05-25 07-03-52

The export option works fine now.

Bildschirmfoto von 2021-05-25 07-04-12

eselmeister commented 3 years ago

Though this issue was a bit more complex than anticipated, many issues needed for the following issue have been implemented yet: https://github.com/eclipse/swtchart/issues/236