eclipse / swtchart

Eclipse Public License 2.0
44 stars 41 forks source link

Arbitrary base logarithmic scale scale #290

Closed Sebdar closed 2 years ago

Sebdar commented 2 years ago

Hello! I am currently using SWTChart in a different Eclipse project and needed to use a base-2 logarithmic scale on both axes.

I added two new public methods to the IAxis interface :

The default behaviour is unchanged, the axis will use a decimal logarithm by default. I added some test cases as well for potential invalid bases. I would love to get some feedback on this (short) pull request.

Thank you!

eselmeister commented 2 years ago

@Sebdar Thanks for your interest in SWTChart and the PR. I will do a review soon.

eselmeister commented 2 years ago

Your PR looks fine. Thanks for providing this improvement. Two small issues need to be addressed:

Update the year in the copyright header of all changed files to 2022, e.g.: * Copyright (c) 2008, 2022 SWTChart project.

Add yourself to the contributors list, e.g.:

 * Contributors:
 * yoshitaka - initial API and implementation
 * Philip Wenig - option to skip drawing the axis line
 * Sebastien Darche - Implement arbitrary base log scale
Sebdar commented 2 years ago

Thank you so much for your feedback. I just pushed the small modifications you requested

eselmeister commented 2 years ago

Thanks for supporting SWTChart!