search

eclipse / swtchart

Eclipse Public License 2.0
45 stars 41 forks source link

Fix resource leak issue - 372 #383

Closed raghucssit closed 8 months ago

raghucssit commented 8 months ago

Scenario - If we have multiple level of parents for chart widget and If we dispose bottom most(top most is chart) widget by invoking dispose chart widget get disposed without calling chart.dispose(). Any subsequent call to dispose never calls dispose for it's children. So checking if chart disposed in the dispose method never give an opportunity to children dispose in the above Scenario. I have added chart disposed safety check at Title because this was causing the issue https://github.com/eclipse/swtchart/issues/289.

Fixes https://github.com/eclipse/swtchart/issues/372

raghucssit commented 8 months ago

@eselmeister please check my changes for #372.

raghucssit commented 8 months ago

BarChartExampleModified.txt Please use this modified bar chart example to see if we close the shell then chart.dispose() never gets called by default. I have shell dispose listener and recreated the problem there.

eselmeister commented 8 months ago

@raghucssit Thanks for your PR. Please extend the year (copyright header) in the modified files. If it was was e.g. 2022, 2023 before, the adjusted header should be 2022, 2024.

I'm on a business trip today. I'll review your changes tomorrow.

eselmeister commented 8 months ago

@raghucssit The change looks principally ok, but you need to address the above marked license header issue.

raghucssit commented 8 months ago

@raghucssit The change looks principally ok, but you need to address the above marked license header issue.

Fixed.

raghucssit commented 7 months ago

@eselmeister Can you please tell me what is the next release plan for swtchart ? We will be happy to use next version of it as soon as it is shipped.