eclipse / tahu

Eclipse Tahu addresses the existence of legacy SCADA/DCS/ICS protocols and infrastructures and provides a much-needed definition of how best to apply MQTT into these existing industrial operational environments.
https://eclipse.org/tahu
Eclipse Public License 2.0
216 stars 123 forks source link

Template Param Value in JS missing DateTime #381

Open ArFe opened 2 months ago

ArFe commented 2 months ago

The Template Param Value function is missing DateTime in its JS Sparkplug Payload function.

It should be as simple as this o fix:

       case 13: // DateTime
            if (isSet(object.longValue)) return object.longValue;

https://github.com/eclipse/tahu/blob/5736e404889d4b95910613040a99ba79589ffb13/javascript/core/sparkplug-payload/lib/sparkplugbpayload.ts#L239-L242

Well, according to the documentation (https://www.eclipse.org/tahu/spec/sparkplug_spec.pdf page 75), it should support all "Basic Data Types" (same document, page 84), so there's actually more missing.