search

eclipse / tinydtls

Eclipse tinydtls
https://projects.eclipse.org/projects/iot.tinydtls
Other
105 stars 57 forks source link

dtls_debug.c: only enable _GNU_SOURCE for MinGW builds. #226

Closed SebastianSchueller closed 4 months ago

SebastianSchueller commented 7 months ago

fixes #225

SebastianSchueller commented 7 months ago

Sorry, I can't seem to get the ECA done, it fails with some "unknown error".

boaks commented 6 months ago

Maybe good news:

"There is a valid ECA on file for sebastian.schueller@grandcentrix.net."

boaks commented 6 months ago

@mrdeep1 @obgm

In the discussions about PR #216 and PR #218 in order to fix issue #213 we decided to go for #218 adding "_GNU_SOURCE". Seems, that this doesn't work for at least Zephyr.

What would be your preferred way to fix it? Using "IS_WINDOWS" ? Or "not WITH_ZEPHYR"? Or ... ?

(Not sure, how "_GNU_SOURCE" works on the windows native tool chain.)

mrdeep1 commented 6 months ago

As the only identified issue so far with the printf format %z is for Windows, I would go for the suggested method of wrapping the inclusion of _GNU_SOURCE with IS_WINDOWS.

boaks commented 6 months ago

LGTM

boaks commented 4 months ago

@obgm

Your feedback?

obgm commented 4 months ago

LGTM