Don't report errors to be consistent with the rest of the class

[iloveeclipse]

Fixes https://github.com/eclipse/tm4e/issues/661

[sebthom]

Do you think instead of swallowing all exceptions we could just ignore logging if a filenotfoundexception is thrown? or log with debug level?

[iloveeclipse]

Do you think instead of swallowing all exceptions we could just ignore logging if a filenotfoundexception is thrown? or log with debug level?

We could, I have even started with that, but this would mean the exceptions shouldn't be handled by the "low level" code as of today and propagated back to callers (which have context and can sort out if they want / won't report an error).

But that would be exact the opposite of what was done in 0.9.0 and the effort isn't justified.

In general, looking on similar code in my workspace I see that most of the "content probe" code mutes any errors anyway as it very seldom that an "probe error" is interesting for anyone except the bundle code owner.

So I've finally decided to go along with the rest of the class (which ignores errors) and be consistent :-)

[iloveeclipse]

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:4.0.4:validate-version (default-validate-version) on project org.eclipse.tm4e.ui: Unqualified OSGi version 0.9.1.qualifier must match unqualified Maven version 0.9.0-SNAPSHOT for SNAPSHOT builds -> [Help 1]

I don't see what is expected now.

• If I don't update manifest, build complains the version hasn't changed.
• If I update manifest, it complains, it doesn't match old version

[sebthom]

I'm looking into it right now.

[sebthom]

can you give this a try? https://github.com/eclipse/tm4e/pull/663