search

eclipse / upm

UPM is a high level repository that provides software drivers for a wide variety of commonly used sensors and actuators. These software drivers interact with the underlying hardware platform through calls to MRAA APIs.
MIT License
658 stars 411 forks source link

BH1749: C/C++ driver implementation with examples #659

Closed Issam-b closed 5 years ago

Issam-b commented 5 years ago

This pull request contains the implementation for the ROHM BH1749 color sensor driver. Samples examples for all 5 supported languages are included.

Issam-b commented 5 years ago

I dunno why this "utilities_unit.test_upm_delay_us" test is failing, but it's not related to this commit for sure.

Issam-b commented 5 years ago

Alright, that's good. About those minor changes, it's OK to correct them when merging, but can you point them out, since I'll be adding another sensor soon, and it's better not to have the same issues again!

Propanu commented 5 years ago

For the JSON file it's mostly a matter of formatting, some of the entries there can be kept on a single line for readability, looks good otherwise.

On the other hand, the .hpp file needs a "library block" so that the page generated from it gets linked in the documentation (see this page). I recommend using an existing sensor driver as a guide, for instance TCS3414 would be a good one. You can find more details on this in the document here. If you want to check how it looks before submitting a PR, it helps to enable documentation during builds. This does have some additional dependencies (explained in building.md file) thus it's understandable if you decide to skip this.

Propanu commented 5 years ago

Merged with some minor formatting changes (see 89e2ec870a90aebb0684cce2d1b3df7a47b837cf). Thanks!