upm shouldn't use deprecated v8 IdleNotification as fails to build on nodejs 10 - Githubissues

eclipse / upm

UPM is a high level repository that provides software drivers for a wide variety of commonly used sensors and actuators. These software drivers interact with the underlying hardware platform through calls to MRAA APIs.

MIT License

661 stars 410 forks source link

upm shouldn't use deprecated v8 IdleNotification as fails to build on nodejs 10 #665

Closed nullr0ute closed 6 years ago

nullr0ute commented 6 years ago

upm 1.7.0 doesn't build with nodejs 10.x due to use of the long deprecated IdleNotification API in a few locations.

According to the v8 API docs IdleNotification went through the following changes:

v8 API 4.1: has been deprecated use IdleNotificationDeadline instead
v8 API 4.3: has been deprecated use IdleNotificationDeadline instead
v8 API 6.5: removed it altogether https://docs.google.com/document/d/1g8JFi8T_oAE_7uAri7Njtig7fKaPDfotU6huOa1alds/edit#!

The docs for API says it shouldn't be used at all.

It's been documented in nodejs since at least 7.x https://v8docs.nodesource.com/node-7.10/d5/dda/classv8_1_1_isolate.html#addafc9c3f09ea1392f862c5fac69be64

At least for the time being IdleNotificationDeadline should be used instead

pylbert commented 6 years ago

Fixed by #666