[unitaryhack] feat: try-catch on plugin loading

[anushkrishnav]

Added a try-catch block inside the plugin loading loop to handle load failure Issues #517

[amccaskey]

Hey @anushkrishnav a few things here. First off you need to make sure that you sign your commits and that your email in the signature matches the email on your Eclipse account. You need to have an Eclipse account and make sure you go in and sign the contributor licensing agreement. Without this the PR will not pass the IP checks.

Next thing - the current code commit you have will not address the issue. The plugin loading error is happening at the Start() method invocation. It is wrapped in a try catch, we really just need that snippet to be updated to throw a warning instead of an error (which causes the framework to stop). A warning here will let the framework continue running, but will just not have the erroneous plugin available.

[amccaskey]

Though - you might also keep a try / catch around the InstallBundles calls too. Just make sure you issue a warning instead of an error.

[anushkrishnav]

Hey @anushkrishnav a few things here. First off you need to make sure that you sign your commits and that your email in the signature matches the email on your Eclipse account. You need to have an Eclipse account and make sure you go in and sign the contributor licensing agreement. Without this the PR will not pass the IP checks.

Next thing - the current code commit you have will not address the issue. The plugin loading error is happening at the Start() method invocation. It is wrapped in a try catch, we really just need that snippet to be updated to throw a warning instead of an error (which causes the framework to stop). A warning here will let the framework continue running, but will just not have the erroneous plugin available.

SO basically instead of a xacc:error it needs to use xacc::exception

[amccaskey]

Instead of xacc::error it should be xacc::warning.

[anushkrishnav]

Done