search

eclipse / xacc

XACC - eXtreme-scale Accelerator programming framework
https://xacc.readthedocs.io
BSD 3-Clause "New" or "Revised" License
165 stars 85 forks source link

Removed failing tests, cleaned up parameter shift #558

Closed danclaudino closed 1 year ago

danclaudino commented 1 year ago

The straightforward parameter-shift rule is meant for generators that have two unique eigenvalues. This PR removes that deuteron tests because the generator in this ansatz has more than two unique eigenvalues, so it may fail (and indeed it does). Also, the current implementation assumes each parameter appears only once in the ansatz. I'll eventually extend the functionality to multiple occurrences of the same parameter.

1tnguyen commented 1 year ago

@danclaudino Thanks for the update. It looks like the email address daniel.pchem@gmail.com is not associated with your Eclipse account hence the ECA validation failed.