search

eclipse / xacc

XACC - eXtreme-scale Accelerator programming framework
https://xacc.readthedocs.io
BSD 3-Clause "New" or "Revised" License
163 stars 84 forks source link

fix_third_party: set install libdir and fix spdlog includes #570

Closed acastanedam closed 1 year ago

acastanedam commented 1 year ago

With the update of the third-party libraries, qcor's compilation crashes when try to link to the gtest and spdlog installed by xacc. This PR fix that and allows for compilation of qcor without touching qcor's configuration files.

1tnguyen commented 1 year ago

Hi @acastanedam,

Thanks for the contribution. This all looks good. Could you please create an Eclipse account and sign the CLA? I can merge this after the ECA validation passes.

Also, please make sure you sign off all the commits with the same email as the email in your Eclipse account. Your git commit didn't have a signature yet.

Thanks!

acastanedam commented 1 year ago

Hi @1tnguyen ,

thanks for checking it. I did the registration process with ECA and signed the ECLA. About the signature I am not sure, what is happening. On the other, I am not sure if the changes are breaking some of the CI tasks, or this is coming from #569.

1tnguyen commented 1 year ago

The CI check failures above should be fixed in master now. Would you mind merging main into your branch since I don't have write permission? Thanks!

acastanedam commented 1 year ago

Hi @1tnguyen , excuse me for the delay. I've just re-based on the last master and push.