eclipse / xacc

XACC - eXtreme-scale Accelerator programming framework
https://xacc.readthedocs.io
BSD 3-Clause "New" or "Revised" License
165 stars 85 forks source link

Call to MLPACK CMAES is inconsistent with the signature - upperBound and lowerBound are reversed #574

Open rsoftone opened 1 year ago

rsoftone commented 1 year ago

The documentation in MLPACK for the cmaes optimiser is here (lines 87-93):

https://mlpack.org/doc/mlpack-3.0.4/doxygen/cmaes_8hpp_source.html

However, in XACC, the instance of cmaes is created at this line:

https://github.com/eclipse/xacc/blob/d1edaa7ae53edc7e335f46d33160f93d6020aaa3/xacc/optimizer/mlpack/mlpack_optimizer.cpp#L195

It looks like upper and lower are in swapped positions.