search

eclipse / xtext-eclipse

xtext-eclipse
Eclipse Public License 2.0
49 stars 73 forks source link

adapted to needRebuild changes in platform #1869

Closed cdietrich closed 2 years ago

cdietrich commented 2 years ago

adapted to needRebuild changes in platform

cdietrich commented 2 years ago

am not sure if we want to change it. as the class is deprecated am not sure who is using it. what do you think @szarnekow

szarnekow commented 2 years ago

am not sure if we want to change it. as the class is deprecated am not sure who is using it. what do you think @szarnekow

I think the change here is reasonable and good, even though it's a deprecated class. If extra care is supposed to be taken, extract a protected method so clients can override it according to their needs, but I doubt this is warranted.