eclipse / xtext-eclipse

xtext-eclipse
Eclipse Public License 2.0
49 stars 73 forks source link

Changing Java Doc location for classpath jars leads to full builds #1916

Closed cdietrich closed 1 year ago

cdietrich commented 1 year ago

Changing Java Doc location for classpath jars leads to full builds

the guard in org.eclipse.xtext.ui.util.JavaProjectClasspathChangeAnalyzer.isAttachmentChangeOnly(IJavaElementDelta) does not consider it as attachment change only, as there is no child

so we will return false here https://github.com/eclipse/xtext-eclipse/blob/a8094ef531583336bee69037af8c26e9121675f9/org.eclipse.xtext.ui/src/org/eclipse/xtext/ui/util/JavaProjectClasspathChangeAnalyzer.java#L76

To be investigated:

cdietrich commented 1 year ago

actually for all attribute changes there seems to be no children also for ones that are/seem relevant for sure like test

cdietrich commented 1 year ago

Fixed in 2.30