search

eclipse / xtext-eclipse

xtext-eclipse
Eclipse Public License 2.0
49 stars 73 forks source link

Integrate Photon Code Mining API #520

Closed cdietrich closed 6 years ago

cdietrich commented 6 years ago

[Photon] Investigate if we can offer Support for the new CodeLens feature here is the lsp4e bug for that https://bugs.eclipse.org/bugs/show_bug.cgi?id=508458

cdietrich commented 6 years ago

@szarnekow how did we introduce support for stuff that is not in the oldest target platform in the past? do we have a pattern for that

szarnekow commented 6 years ago

There is no pattern yet. We could use Proxy.newInstance combined with a Class.forName and delegate to our own internal methods. So a bunch of reflective code along with the required extension points.

Maybe it's worthwhile to investigate plugin fragments for that purpose.

kthoms commented 6 years ago

We are working on a draft. Looks promising so far.

cdietrich commented 6 years ago

:+1:

cdietrich commented 6 years ago

@kthoms what is the state of this issue?

kthoms commented 6 years ago

We have now Code Mining integration, but would like to offer an adapter to Code Lens.

kthoms commented 6 years ago

Created follow-up issue eclipse/xtext#2468, so we can close the general integration now.