search

eclipse / xtext-lib

Eclipse Xtext™ Libraries
https://www.eclipse.org/Xtext/
Eclipse Public License 2.0
19 stars 33 forks source link

Add mwe.core to xtext-dev-bom #282

Closed LorenzoBettini closed 4 years ago

LorenzoBettini commented 4 years ago

As noted here https://www.eclipse.org/forums/index.php/t/1101550/ mwe.core is not dragged in automatically anymore in Maven builds, and must be explicitly added. If one relies on the xtext-dev-bom it would be nice to add mwe.core to the BOM

Signed-off-by: Lorenzo Bettini lorenzo.bettini@gmail.com

cdietrich commented 4 years ago

@LorenzoBettini as there is no single place in xtext-lib/core/extras with a direct dependency i wonder which problem this solves?

=> should the client use mwe2.lib / runtime / whatever else to pull it transitively (the same thing the upstream xtext component uses)

LorenzoBettini commented 4 years ago

@cdietrich it solves problems for users that have to add an explicit Maven dep in the DSL Maven artifact, e.g., when running xtext-maven-plugin: they don't have to make the version explicit if they use the BOM

cdietrich commented 4 years ago

fine but i wonder why they add mwe.core and not one of the others

cdietrich commented 4 years ago

also: did you double check if there are any other mwe(2) modules to add?

LorenzoBettini commented 4 years ago

For sure I think other mwe(2) modules might be helpful, I just added one that caused a few problems since Xtext 2.20.

szarnekow commented 4 years ago

I'd really prefer to have an end-user bom vs the dev bom.

LorenzoBettini commented 4 years ago

@kthoms in the meantime I'm merging this since I seem to understand that's OK

@szarnekow you mean the end-user BOM should include the dev BOM + dependency management for each xtext Maven artifacts (which I once suggested in the original dev BOM issue)?