eclipse / xtext-lib

Eclipse Xtext™ Libraries
https://www.eclipse.org/Xtext/
Eclipse Public License 2.0
19 stars 33 forks source link

EPL1.0 -> EPL2.0 and contribute.md #297

Closed svenefftinge closed 4 years ago

svenefftinge commented 4 years ago

This PR changes the code license from EPL 1.0 to EPL 2.0 and adds a Contribute.md file.

see https://github.com/eclipse/xtext/issues/1176

cdietrich commented 4 years ago

@svenefftinge looks like you missed half of the header changes

https://www.eclipse.org/projects/handbook/#ip-copyright-headers

see also https://bugs.eclipse.org/bugs/show_bug.cgi?id=530393

cdietrich commented 4 years ago

Things to look at

https://www.eclipse.org/legal/guidetolegaldoc2.php https://www.eclipse.org/projects/handbook/#ip-copyright-headers

waynebeaton commented 4 years ago

I really hate to do this, but... while you updated the URLs correctly, you missed the text in at least some of the headers...

image

cdietrich commented 4 years ago

@svenefftinge nice. looks much better now. still miss an update to the license feature in the target file

svenefftinge commented 4 years ago

Yes, I was still on it. But now I hope I have it. Can you review, please? I'll go through the other PRs once this is good to merge.

cdietrich commented 4 years ago

the target file is still not there. or github does not show it https://github.com/eclipse/xtext-lib/blob/8888f2dc2195ad65565779296bc6ba27031cb1e7/releng/releng-target/xtext-lib.target.target#L10

svenefftinge commented 4 years ago

Thanks, I have updated the target file and replaced the whole contents of the about files.

cdietrich commented 4 years ago

ok will recheck later @szarnekow @miklossy can you please also have a look