Move to Maven/Tycho for projects and build infrastructure

[LorenzoBettini]

Similar to https://github.com/eclipse/xtext-core/issues/2052

[LorenzoBettini]

I started working on that in my fork, this branch https://github.com/LorenzoBettini/xtext-lib/tree/lb_499_maven_tycho

[LorenzoBettini]

@cdietrich do you know if com.google.guava:guava-testlib is available somewhere as a p2 bundle?

[cdietrich]

no, i have zero clue. can you check what it is used for?

[LorenzoBettini]

It's used in org.eclipse.xtext.xbase.lib.tests which is not even an Eclipse plug-in project (no MANIFEST). However, by using the new mechanism of adding Maven deps in the .target file I solved the problem and the code compiles (tests are also green):

        <location includeDependencyDepth="none" includeDependencyScopes="compile" includeSource="true" missingManifest="generate" type="Maven">
            <dependencies>
                <dependency>
                    <groupId>com.google.guava</groupId>
                    <artifactId>guava-testlib</artifactId>
                    <version>30.1-jre</version>
                    <type>jar</type>
                </dependency>
            </dependencies>
            <instructions><![CDATA[
Bundle-Name:           Bundle derived from maven artifact ${mvnGroupId}:${mvnArtifactId}:${mvnVersion}
version:               ${version_cleanup;${mvnVersion}}
Bundle-SymbolicName:   ${mvnGroupId}.${mvnArtifactId}
Bundle-Version:        ${version}
Import-Package:        *;resolution:=optional
Export-Package:        *;version="${version}";-noimport:=true
DynamicImport-Package: *
]]></instructions>
        </location>

[cdietrich]

i assume which of the collections asserts therein are actually used and if we can replace it with something else

[LorenzoBettini]

import com.google.common.collect.testing.MapTestSuiteBuilder;
import com.google.common.collect.testing.TestStringMapGenerator;
import com.google.common.collect.testing.features.CollectionFeature;
import com.google.common.collect.testing.features.CollectionSize;
import com.google.common.collect.testing.features.MapFeature;

in org.eclipse.xtext.xbase.tests.lib.MapExtensionsTest

[cdietrich]

ok, then i guess we can try if maven dep works

[LorenzoBettini]

It's also used extensively in the test suites (I seem to understand that it executes tests in that very dependency).

[LorenzoBettini]

@cdietrich some updates: I still have to deal with gwt. Everything else builds and tests are green!

[LorenzoBettini]

@cdietrich concerning GWT: I have no idea of what to do with those projects (I seem to recall what GWT is but I have only a very primordial idea)...

[cdietrich]

am not sure if we want to keep it or not unfortunately nobody has knowledge see https://github.com/eclipse/xtext/issues/2241 @mbudnick are you still using xtend+gwt and do you have experience with gwt and maven?

[LorenzoBettini]

I mean: I can try to create the packages but I have no idea of how they should look like (of course there are tests and I can run them).

Moreover, there's dependency in the gradle file api "com.google.guava:guava-gwt" while in the MANIFEST we simply have com.google.guava... are they the same?

[cdietrich]

you need to check the binary files i guess

[cdietrich]

maybe https://github.com/eclipse/xtext/tree/v2.10.0/plugins/org.eclipse.xtend.lib.gwt can also help to archeologize

[LorenzoBettini]

yes, that put me on the right track. All projects compile, and all tests are green (including the xtend.lib.gwt.test)!!! :)

[LorenzoBettini]

@cdietrich as I said in my previous comment, everything compiles, builds and tests are green (including gwt).

I seem to understand that gwt stuff must NOT be in the update site, am I right? Currently, there are still two features for gwt to be included in the p2 repository.

[cdietrich]

yes it looks like they are published to maven only

[mbudnick]

@mbudnick are you still using xtend+gwt and do you have experience with gwt and maven?

@cdietrich yes, we use org.eclipse.xtext:org.eclipse.xtext.xbase.lib.gwt from Maven Central Repository. If there is a milestone-version or a snapshot-version in an other respository I can test it.

[cdietrich]

ok, so as soon as @LorenzoBettini moves this to our jenkins we will have a maven repo to test

[LorenzoBettini]

@cdietrich @mbudnick I've just pushed my branch and Jenkins built it successfully (I'll create a PR in a minute).

That's the generated Maven repository generated from my branch: https://ci.eclipse.org/xtext/job/xtext-lib/job/lb_499_maven_tycho/lastSuccessfulBuild/artifact/build/maven-repository/

[mbudnick]

My gwt-app has no problem with 2.30.0-SNAPSHOT.

[cdietrich]

done