Replace deprecated XbaseScopeProvider with current THIS constant

eclipse / xtext-website

2 stars 23 forks source link

Replace deprecated XbaseScopeProvider with current THIS constant #16

Closed stevehickman closed 1 year ago

stevehickman commented 1 year ago

The ECA has been updated. How does the test get re-run?

cdietrich commented 1 year ago

I hit revalidate but the tool still does not like the commit

cdietrich commented 1 year ago

usual steps to commit are

clone repo
configure git to use name and email as in eclipse
commit changes with sign-off (git -s)
create pr

stevehickman commented 1 year ago

I did all this editing directly on GitHub where I am logged in. That forked the repo, created the branch, and signed the commit. I'm currently logged in via the email that is associated with my Eclipse ID. I followed the link on this PR to my Eclipse ID and signed the ECA after the first commit. I added the second commit just in case that would help.

I will now try doing this locally.

stevehickman commented 1 year ago

See https://github.com/eclipse/xtext-website/pull/18 instead