eclipse / xtext-website

2 stars 23 forks source link

Update 340_lsp_support.md #26

Closed crapo closed 1 month ago

crapo commented 9 months ago

Added brief instructions on how to add TextMate grammar.

cdietrich commented 9 months ago

@crapo would be so kind an check if you still have a valid eca signed? https://www.eclipse.org/legal/ECA.php

crapo commented 9 months ago

I've completed an ECA.

LorenzoBettini commented 4 months ago

@cdietrich can we merge this one?

cdietrich commented 4 months ago

My question is not answered

LorenzoBettini commented 4 months ago

which one?

cdietrich commented 4 months ago

If it works in eclipse help Don’t have a machine with me where I have the ruby stuff set up.

LorenzoBettini commented 4 months ago

@crapo maybe it's better if you put the PNG image in the images directory like we did for other images

miklossy commented 1 month ago

@crapo maybe it's better if you put the PNG image in the images directory like we did for other images

Since the PNG image has been put into the images directory (see https://github.com/eclipse/xtext-website/pull/26/commits/210194077bc679a5f8160abd3d18c5fd61aa1e98), I think we could merge this PR.

@LorenzoBettini @cdietrich what do you think?

cdietrich commented 1 month ago

i wonder if we can cleanup the commit history

crapo commented 1 month ago

If that is directed at me, I'm not sure exactly what that means or how to do it.

cdietrich commented 1 month ago

yes i wonder if you can rebase and squash all your changes into one commit

LorenzoBettini commented 1 month ago

@cdietrich we can do that ourselves when merging (Squash and merge)

cdietrich commented 1 month ago

@LorenzoBettini if you could do that i am fine with it