Update to EMF 2.15 (or later)

cdietrich commented 5 years ago

update maven and gradle builds (see integ tests too)
update manifests
maybe update wizard
test

kthoms commented 5 years ago

EMF 2.15 release is out and available on Maven Central.

cdietrich commented 5 years ago

moved to 2.17 since this depends on BOM will move to 2.17

cdietrich commented 5 years ago

Moved to 2.19

cdietrich commented 5 years ago

it looks like ed has already published emf 2.18 to maven central

cdietrich commented 4 years ago

If i were sure this would work perfectly fine with older eclipse versions (back to oxygen) Then https://github.com/eclipse/xtext/issues/1282 Would be long done.

Currently I have nobody that could support me with that

I am also not sure if forcing the new EMf Version on older eclipses Or setting the Genmodel/ runtime version to the one of oxygen is the right way to go

cdietrich commented 4 years ago

@tivervac what do you think. You are one of the reasons to stick with oxygen

cdietrich commented 4 years ago

Meanwhile Ed has published 2.19

tivervac commented 4 years ago

@cdietrich Do you have any specific concerns with EMF > 2.14 and Oxygen, or do you just have no idea if they still work together? We can test it on our side but we'll need a little bit of time

cdietrich commented 4 years ago

I want to make sure it works with old emf too if somebody picks Oxygens emf version (don’t know how you handle that(

tivervac commented 4 years ago

I'll raise the issue internally and get back to you

cdietrich commented 4 years ago

@tivervac any news?

tivervac commented 4 years ago

We had a release last week so this was delayed, but I'm working on it now.

miklossy commented 4 years ago

Please consider that the Xtext-Examples (e.g Domainmodel.genmodel) specifies runtimeVersion="2.12" I think that would also worth updating.

@cdietrich Or will it be automatically updated when regenerated?

cdietrich commented 4 years ago

yes and no and this is one point to investigate

if there is no version in workflow the default, aka the one on classpath will be used,
so in gradle / maven the one in the bom will be used
in pure eclipse the one installed in eclipse will be used. so this will be a problem if we dont install a newer emf than the one from oxygen on oxygen (or we have to use the non existing maven version 2.13 from oxygen which is no advancement from current 2.12)

cdietrich commented 4 years ago

=> options would be

use newer runtime version in bom and eclipse (and workflows/genmodels)
user newer version in bom but old version in workflows explicetly and keep older version in manifests/eclipse

tivervac commented 4 years ago

We've tried the following: In Eclipse 4.7.3 on CentOS 6.10 (final) we added the update site http://download.eclipse.org/modeling/emf/emf/builds/release/2.19 and manually installed/updated EMF. We now have the EMF Common 2.16.0.v20190625-1131 and EMF Ecore 2.19.0.v20190822-1451.

Everything still seems to work.

cdietrich commented 4 years ago

=> the assumption is that using a "newer" emf version of oxygen should work fine. TBD:

use runtimeVersion from oxygen
use newer runtimeVersion and adapt manifests to require newer in eclipse (+ adapt affected target platforms)

cdietrich commented 4 years ago

unfortunately the runtime version from oxygen is still outdated regarding @override and StringBuffer & co

miklossy commented 4 years ago

What does it exactly mean?

cdietrich commented 4 years ago

if does not generated override annotation and uses old stingbuffer

cdietrich commented 4 years ago

=> i wonder if we should use a newer emf (runtime) even in minimal target is oxygen

miklossy commented 4 years ago

Oh, ok, I understand.

cdietrich commented 4 years ago

move to 2.21

cdietrich commented 4 years ago

Meanwhile EMF 2.20 is on maven central

szarnekow commented 4 years ago

Great job @cdietrich! With these branches in my working copy, I do only have EObject from 2.20 in my JDT index. Remaining: Remove the outdated "## Maven Tycho Hints" from the documentation.

cdietrich commented 4 years ago

which hints do you mean? do you mean updating the table?

can you please rebase and build all branches?

szarnekow commented 4 years ago

updating the table

Yes, exactly. The table in xtext-website/documentation/350_continuous_integration.md is unnecessarily confusing given that we build against emf 2.20

rebase

Will do

cdietrich commented 4 years ago

@szarnekow i wonder if we should mention the current instead of any old emf version in the table. what do you think?

(replace the 2.17s with the emf version of that release)

cdietrich commented 4 years ago

i also wonder if i should sequash the commits. i did create separate ones to ease review

miklossy commented 4 years ago

I think in such huge change it is better to keep the commits separate.

szarnekow commented 4 years ago

@szarnekow i wonder if we should mention the current instead of any old emf version in the table. what do you think?

(replace the 2.17s with the emf version of that release)

Yes, that sounds good.

cdietrich commented 4 years ago

@szarnekow i updated the PR. please check

cdietrich commented 4 years ago

lets see if there are any leftovers

cdietrich commented 4 years ago

@ArneDeutsch is going to fix broken xtext-maven-plugin tests. were not discovered due broken test result reporting on jenkins

cdietrich commented 4 years ago

no more regressions reported so far. so will close for now. if you find new problems please report a new issue

eclipse / xtext

Update to EMF 2.15 (or later) #1282