search

eclipse / xtext

Eclipse Xtext™ is a language development framework
http://www.eclipse.org/Xtext
Eclipse Public License 2.0
754 stars 317 forks source link

[releng] Change target file name for p2 repository for stable/release builds #1472

Closed kthoms closed 5 years ago

kthoms commented 5 years ago

The publishing plugin packages the p2 repository in the zipXtextP2Repository step to a zip with pattern tmf-xtext-Update-<BUILDTYPE><TIMESTAMP>.zip. For build type "S" and "R" the zip should contain the release name (e.g. tmf-xtext-Update-2.18.0.M3.zip)

kthoms commented 5 years ago

The related code is in EclipsePublishing.xtend, line 175ff.

val zipP2RepoTask = tasks.create('''zip«repoName»P2Repository''', Zip)

cdietrich commented 5 years ago

@kthoms would that solve https://bugs.eclipse.org/bugs/show_bug.cgi?id=522525

kthoms commented 5 years ago

Yes, this should solve that.

kthoms commented 5 years ago

https://www.eclipse.org/modeling/tmf/downloads/

2.18.0.M3 has been named properly. Older milestones have still S<BUILD_ID>.

screenshot 97

trancexpress commented 5 years ago

I tried downloading the M3 build from this link:

https://www.eclipse.org/downloads/download.php?file=/modeling/tmf/xtext/downloads/drops/2.18.0/S201905280716/tmf-xtext-Update-S201905280716.zip

Eclipse downloads - file unavailable

The selected file is invalid, or it is no longer available for download.

This happens when the file is part of a nightly or development build. If so, please return to the project's home page and download a newer version.

Also tried to navigate to the 28.05.2019 build from here:

https://www.eclipse.org/downloads/download.php?file=/modeling/tmf/xtext/downloads/drops/

The mirrors I've automatically been assigned to don't have any contents for this build, see e.g.:

http://eclipse.mirror.garr.it/eclipse/modeling/tmf/xtext/downloads/drops/2.18.0/S201905280716/

I have been able to download from the official M3 link though:

https://www.eclipse.org/downloads/download.php?file=/modeling/tmf/xtext/downloads/drops/2.18.0/S201905280716/tmf-xtext-Update-2.18.0.M3.zip

Not sure if the above is expected, in particular @cdietrich pinged me about the xtext 2.18 M3 build with a non-working link:

http://www.eclipse.org/modeling/download.php?file=/modeling/tmf/xtext/downloads/drops/2.18.0/S201905280716/tmf-xtext-Update-S201905280716.zip

cdietrich commented 5 years ago

@kthoms when do the file names change? i copied the name from here. https://www.eclipse.org/modeling/tmf/downloads/