search

eclipse / xtext

Eclipse Xtext™ is a language development framework
http://www.eclipse.org/Xtext
Eclipse Public License 2.0
763 stars 318 forks source link

Marketplace entry validation failure #1632

Closed kthoms closed 4 years ago

kthoms commented 4 years ago

The Marketplace validation report shows issues with the Xtext SDK for platforms below 2019-12:

screenshot 363

Clicking on an error icon reveals problems with the dependency on MWE:

Contains: Missing requirement: Xtext Complete SDK 2.20.0.v20191202-1256 (org.eclipse.xtext.sdk.feature.group 2.20.0.v20191202-1256) requires 'org.eclipse.equinox.p2.iu; org.eclipse.emf.mwe2.language.sdk.feature.group 2.11.1' but it could not be found

MWE 2.11.1 can be found on the 2019-12 SimRel, but not on SimRel repositories of older releases.

kthoms commented 4 years ago

screenshot 364

kthoms commented 4 years ago

Should the MWE site be listed in the category.xml of Xtext's p2 repository? xtext-eclipse/releng/org.eclipse.xtext.p2-repository/category.xml

screenshot 365

cdietrich commented 4 years ago

am not sure isnt that what the xtext composite is for.

cdietrich commented 4 years ago

i wonder

cdietrich commented 4 years ago

this not only affects MWE but will also EMF if e.g. we require EMF 2.20

kthoms commented 4 years ago

Could reproduce the issue with the p2 director app on a fresh Oxygen installation.

Steps to reproduce:

Run director app with

director -r http://download.eclipse.org/modeling/tmf/xtext/updates/releases/2.20.0,http://download.eclipse.org/releases/oxygen -i org.eclipse.xtext.sdk.feature.group -d ~/temp/java-oxygen/

=> 


Installing org.eclipse.xtext.sdk.feature.group 2.20.0.v20191202-1256.
Installation failed.
Cannot complete the install because one or more required items could not be found.
 Software being installed: Xtext Complete SDK 2.20.0.v20191202-1256 (org.eclipse.xtext.sdk.feature.group 2.20.0.v20191202-1256)
 Missing requirement: Xtext Complete SDK 2.20.0.v20191202-1256 (org.eclipse.xtext.sdk.feature.group 2.20.0.v20191202-1256) requires 'org.eclipse.emf.mwe2.language.sdk.feature.group 2.11.1' but it could not be found
kthoms commented 4 years ago

Installing Xtext 2.20 on 2019-12 works

director -r http://download.eclipse.org/modeling/tmf/xtext/updates/releases/2.20.0,http://download.eclipse.org/releases/2019-12 -i org.eclipse.xtext.sdk.feature.group -d ~/temp/java-latest/
kthoms commented 4 years ago

Discussed with @Hejado and we came to the solution to provide an update site at location http://download.eclipse.org/modeling/tmf/xtext/updates/composite/marketplace

We'll add this composite to https://github.com/xtext/xtext-p2-orbit and revive the Jenkins job that copies the manually maintained composite descriptors to Xtext's project storage.

Also raised an Bug#558359 for Marketplace Client, since we can't specify multiple solution versions with the same set of supported Eclipse releases.

kthoms commented 4 years ago

Marketplace entry is valid again

screenshot 374