search

eclipse / xtext

Eclipse Xtext™ is a language development framework
http://www.eclipse.org/Xtext
Eclipse Public License 2.0
766 stars 320 forks source link

Go through API Diff report and check for unwanted changes due Xtend 2 Java mig #1733

Closed cdietrich closed 4 years ago

cdietrich commented 4 years ago

Go through API Diff report and check for unwanted changes due Xtend 2 Java mig

https://ci.eclipse.org/xtext/job/releng/job/xtext-xtend-api-diff

cdietrich commented 4 years ago 
public class  org.eclipse.xtext.xbase.ui.editor.XbaseEditorInputRedirector
Status | Modifier | Type | Method
-- | -- | -- | --
REMOVED                 (!) | protected | org.eclipse.jdt.core.IPackageFragmentRoot | _getPackageFragmentRoot(org.eclipse.jdt.core.IJavaElement)
REMOVED                 (!) | protected | org.eclipse.jdt.core.IPackageFragmentRoot | _getPackageFragmentRoot(org.eclipse.jdt.core.IPackageFragmentRoot)
REMOVED                 (!) | protected | org.eclipse.jdt.core.IPackageFragmentRoot | _getPackageFragmentRoot(java.lang.Void)

@szarnekow do we want these changes?

szarnekow commented 4 years ago

I think this particular case is fine.

miklossy commented 4 years ago

I went through the API diff report and did not find any unwanted changes.

Closing as fixed in 2.22.