eclipse / xtext

Eclipse Xtext™ is a language development framework
http://www.eclipse.org/Xtext
Eclipse Public License 2.0
767 stars 321 forks source link

Add Support for Quick Assist API #2379

Open cdietrich opened 6 years ago

cdietrich commented 6 years ago

Xtext should offer the possibility to quick assist without using issues / quickfixes

XtextQuickAssistProcessor currently supports quickfixes only (see org.eclipse.xtext.ui.editor.quickfix.XtextQuickAssistProcessor.canAssist(IQuickAssistInvocationContext))

miklossy commented 6 years ago

See also https://bugs.eclipse.org/bugs/show_bug.cgi?id=321684

ArneDeutsch commented 6 years ago

I have had a look to the discussion of the referenced ticket and the provided patch. It is now quite dated (2010) but I wonder if the discussion results are still valid. Especially I do not understand the following: Why to avoid a new term "suggestion"? If I would try to implement it I would probably do it similar because a the assistent does not fix any issue. Right now I can not imagine how a more "homogeneous" solution could look like.