Storage2UriMapperJavaImpl.getStorages is unnecessarily slow

eclipse / xtext

Eclipse Xtext™ is a language development framework

http://www.eclipse.org/Xtext

Eclipse Public License 2.0

768 stars 321 forks source link

Storage2UriMapperJavaImpl.getStorages is unnecessarily slow #2381

Open szarnekow opened 2 years ago

szarnekow commented 2 years ago

It traverses the list of all package fragment roots twice and performance pointless exists() check apparently only to modify a local copy of the data.

Can be observed on workspaces with large number of projects.

See org.eclipse.xtext.ui.resource.Storage2UriMapperJavaImpl.getStorages(URI)

cdietrich commented 2 years ago

@szarnekow is this done?

szarnekow commented 2 years ago

There is still headroom, but not without new APIs. Still pondering.

cdietrich commented 1 year ago

move to 2.30