Xtext outline icons are confusing

eclipse / xtext

Eclipse Xtext™ is a language development framework

http://www.eclipse.org/Xtext

Eclipse Public License 2.0

753 stars 317 forks source link

Xtext outline icons are confusing #2383

Open szarnekow opened 4 years ago

szarnekow commented 4 years ago

Two times the same icon. One action is to enable filtering of terminal rules, the other action will show / hide the return types. The icon does not make much sense for either of these actions.

miklossy commented 4 years ago

Maybe we could use this icon for the terminal rules: terminal_node

szarnekow commented 4 years ago

:+1:

miklossy commented 3 years ago

@drkstr101 Would be awesome if you could take care of this issue.

drkstr101 commented 3 years ago

@miklossy Yes I can do this. Should be an easy fix.

drkstr101 commented 3 years ago

@szarnekow @miklossy I'm actually having trouble finding where this icon is referenced. It doesn't appear to be in o.e.xtext.ui/icons. I see the other icons in there referenced in org.eclipse.xtext.ui.internal.XtextPluginImages, so I was looking for an entry somewhere in that class to swap out the icon asset. Is my understanding of where this change needs to go correct?

cdietrich commented 3 years ago

see https://github.com/eclipse/xtext-eclipse/blob/3cc3e8cfbfc2669de731ee742783aff57ded076c/org.eclipse.xtext.xtext.ui/src/org/eclipse/xtext/xtext/ui/editor/outline/FilterTerminalRulesContribution.java#L54

and

https://github.com/eclipse/xtext-eclipse/blob/3cc3e8cfbfc2669de731ee742783aff57ded076c/org.eclipse.xtext.xtext.ui/src/org/eclipse/xtext/xtext/ui/editor/outline/HideReturnTypesContribution.java#L44

drkstr101 commented 3 years ago

See: https://github.com/eclipse/xtext-eclipse/pull/1509

cdietrich commented 3 years ago

moved out of 2.24