search

eclipse / xtext

Eclipse Xtext™ is a language development framework
http://www.eclipse.org/Xtext
Eclipse Public License 2.0
766 stars 319 forks source link

Wizard: Experiment with the new Tycho P2 feature that support consuming maven artifacts from target platform #2471

Open cdietrich opened 3 years ago

cdietrich commented 3 years ago

Wizard: Experiment with the new Tycho P2 feature that support consuming maven artifacts from target platform

cc @LorenzoBettini

in target

        <location missingManifest="generate" type="Maven">
            <groupId>org.eclipse.xtext</groupId>
            <artifactId>xtext-antlr-generator</artifactId>
            <version>2.1.1</version>
            <type>jar</type>
        </location>
        <location missingManifest="generate" type="Maven">
            <groupId>org.xtext</groupId>
            <artifactId>antlr-generator</artifactId>
            <version>3.2.1</version>
            <type>jar</type>
        </location>

in build.properties from mydsl

                     wrapped.org.eclipse.xtext.xtext-antlr-generator, \
                     wrapped.org.xtext.antlr-generator

seems to require org.eclipse.m2e.pde.feature.feature.group to work from eclipse. the antlr generator then no longer needs to be consumed from exec plugin call in mydsl

LorenzoBettini commented 3 years ago

@cdietrich and also tweak the exec-maven-plugin configuration accordingly

Do you happen to know whether that feature is installed by default in Eclipse distributions?

cdietrich commented 3 years ago

no in dont know. the question is if it is properly ignored or if it will fail if it does not know the thing in the .target file

cdietrich commented 3 years ago 
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<?pde version="3.8"?>
<target name="org.xtext.example.mydsl.target" sequenceNumber="1">
    <locations>
        <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
            <unit id="org.eclipse.jdt.feature.group" version="0.0.0"/>
            <unit id="org.eclipse.platform.feature.group" version="0.0.0"/>
            <unit id="org.eclipse.pde.feature.group" version="0.0.0"/>
            <unit id="org.eclipse.draw2d.feature.group" version="0.0.0"/>
            <unit id="org.eclipse.emf.sdk.feature.group" version="0.0.0"/>
            <repository location="https://download.eclipse.org/releases/2021-09"/>
        </location>
        <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
            <unit id="org.eclipse.emf.mwe2.launcher.feature.group" version="0.0.0"/>
            <repository location="https://download.eclipse.org/modeling/emft/mwe/updates/releases/2.12.1/"/>
        </location>
        <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
            <unit id="org.eclipse.xtext.sdk.feature.group" version="0.0.0"/>
            <repository location="https://download.eclipse.org/modeling/tmf/xtext/updates/nightly/"/>
        </location>
        <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
            <unit id="com.google.gson" version="2.8.7.v20210624-1215"/>
            <unit id="com.google.inject" version="3.0.0.v201605172100"/>
            <unit id="javax.inject" version="1.0.0.v20091030"/>
            <unit id="org.antlr.runtime" version="3.2.0.v201101311130"/>
            <unit id="org.junit" version="4.12.0.v201504281640"/>
            <unit id="org.junit.jupiter.api" version="5.7.1.v20210222-1948"/>
            <unit id="org.junit.jupiter.engine" version="5.7.1.v20210222-1948"/>
            <unit id="org.junit.platform.commons" version="1.7.1.v20210222-1948"/>
            <unit id="org.junit.platform.engine" version="1.7.1.v20210222-1948"/>
            <unit id="org.junit.platform.launcher" version="1.7.1.v20210222-1948"/>
            <unit id="org.junit.platform.runner" version="1.7.1.v20210222-1948"/>
            <unit id="org.opentest4j" version="1.2.0.v20190826-0900"/>
            <unit id="org.objectweb.asm" version="9.1.0.v20210209-1849"/>
            <unit id="org.objectweb.asm.tree" version="9.1.0.v20210209-1849"/>
            <unit id="io.github.classgraph" version="4.8.35.v20190528-1517"/>
            <repository location="https://download.eclipse.org/tools/orbit/downloads/2021-09"/>
        </location>
        <location missingManifest="generate" type="Maven">
            <groupId>org.eclipse.xtext</groupId>
            <artifactId>xtext-antlr-generator</artifactId>
            <version>2.1.1</version>
            <type>jar</type>
        </location>
        <location missingManifest="generate" type="Maven">
            <groupId>org.xtext</groupId>
            <artifactId>antlr-generator</artifactId>
            <version>3.2.1</version>
            <type>jar</type>
        </location>
    </locations>
</target>

checkout

<location includeDependencyScope="compile" missingManifest="generate" type="Maven">

for transitivity