Fragment org.eclipse.xtext.common.types.shared.jdt38 of org.eclipse.xtext.common.types.shared depends on org.eclipse.xtext.xbase.ui

trancexpress commented 5 years ago

We see the following "dependency cycle" reported by https://github.com/iloveeclipse/plugindependencies

org.eclipse.xtext.xbase.ui 2.17.1.v20190402-1603 org.eclipse.xtext.common.types.shared 2.17.1.v20190402-1603 org.eclipse.xtext.common.types.shared.jdt38 2.17.1.v20190402-1603

org.eclipse.xtext.common.types.shared.jdt38 depends on org.eclipse.xtext.xbase.ui, org.eclipse.xtext.xbase.ui depends on org.eclipse.xtext.common.types.shared. org.eclipse.xtext.common.types.shared.jdt38 is a fragment of org.eclipse.xtext.common.types.shared. This looks weird.

Possibly caused by: https://github.com/eclipse/xtext-eclipse/pull/963

cdietrich commented 5 years ago

TODO:

is this a real problem
revert the pr and find another solution
is the fragment still needed or can and should the code be moved to one of the two plugins

cdietrich commented 4 years ago

moved to 2.22

cdietrich commented 4 years ago

TODO consider gettring rid of the fragment alltogether

cdietrich commented 2 years ago

tycho now starts complaining https://ci.eclipse.org/xtext/job/xtext-eclipse/job/cd_testTycho30/179/console https://github.com/eclipse/tycho/issues/1124

cdietrich commented 2 years ago

@szarnekow do you remember why this is a cycle at all?

eclipse / xtext

Fragment org.eclipse.xtext.common.types.shared.jdt38 of org.eclipse.xtext.common.types.shared depends on org.eclipse.xtext.xbase.ui #2478