search

eclipse / xtext

Eclipse Xtext™ is a language development framework
http://www.eclipse.org/Xtext
Eclipse Public License 2.0
764 stars 319 forks source link

[LanguageServer] Extract standalone bindings from ServerModule #2611

Open spoenemann opened 7 years ago

spoenemann commented 7 years ago

We should create a StandaloneServerModule that extends ServerModule and move all bindings that are only valid in the standalone case to the new class. For example,

bind(IResourceServiceProvider.Registry).toProvider(ResourceServiceProviderServiceLoader)

does not work in all environments. Maybe it would make sense to use AbstractGenericModule so bindings can be overridden.

Furthermore, we should consider creating the executors in a way that they can be shut down in a proper lifecycle, see eclipse/xtext-core#127.

spoenemann commented 7 years ago

We should reconsider this after the release.