search

eclipse / xtext

Eclipse Xtext™ is a language development framework
http://www.eclipse.org/Xtext
Eclipse Public License 2.0
767 stars 321 forks source link

Tycho 2.7.5 + Domain + Wizard dont work on J17 #2849

Open cdietrich opened 11 months ago

cdietrich commented 11 months ago

Tycho 2.7.5 + Domain + Wizard dont work on J17

Caused by: java.lang.ClassNotFoundException: org.apache.maven.surefire.junit4.JUnit4Provider at org.eclipse.tycho.surefire.osgibooter.CombinedClassLoader.findClass(CombinedClassLoader.java:39) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525) at org.apache.maven.surefire.util.ReflectionUtils.loadClass(ReflectionUtils.java:241) ... 19 more

cdietrich commented 11 months ago

https://github.com/eclipse/mwe/issues/275

cdietrich commented 11 months ago

still does not work in integ test crap :(

cdietrich commented 11 months ago

might also be a flakyness on github actions

LorenzoBettini commented 11 months ago

What's the problem?

cdietrich commented 11 months ago

2nd attempt worker but log is still full of warnings

cdietrich commented 11 months ago

@szarnekow @LorenzoBettini can someone look into https://github.com/xtext/xtext-reference-projects/actions/runs/6926300643 is there a way to get screenshots from gh actions?

LorenzoBettini commented 11 months ago

@cdietrich if you mean screenshots generated by SWTBot, this is how I do https://github.com/eclipse-emf-parsley/emf-parsley/blob/master/.github/workflows/maven.yml#L61

cdietrich commented 11 months ago

Yes I mean these

LorenzoBettini commented 11 months ago

concerning the failing test: I'd increase the SWTBot timeout (e.g., -Dorg.eclipse.swtbot.search.timeout=20000), and/or I'd also use flaky test support from Maven/Tycho, how we do in Xtext https://github.com/eclipse/xtext/blob/main/.mvn/maven.config#L3 or how I do in EMF Parsley https://github.com/eclipse-emf-parsley/emf-parsley/blob/master/releng/org.eclipse.emf.parsley.parent/pom.xml#L810C9-L810C9

cdietrich commented 11 months ago

Can you provide pr

LorenzoBettini commented 11 months ago

OK, later today. Do you have any preference for the solutions? I don't remember well how those projects were structured, I hope I find my way ;)

cdietrich commented 11 months ago

There is only one swt project bellow integration tests

cdietrich commented 11 months ago

still flaky.

https://github.com/xtext/xtext-reference-projects/compare/cd_refresh?expand=1

maybe you can also find some time to have a look @LorenzoBettini @szarnekow

LorenzoBettini commented 11 months ago

It says

org.eclipse.swtbot.swt.finder.widgets.TimeoutException: Timeout after: 600000 ms.: Process still not terminated.
    at org.eclipse.xtext.swtbot.tests.XtextNewProjectWizardTest.xtextProject_webIntegration_withGradle_plain(XtextNewProjectWizardTest.java:386)

Can it take so long for the gradle project(s)?

Maybe we can pass a Monitor to waitForBuild that logs what's happening?

I don't think I can work on that today.