eclipseisoffline / customname

This mod adds a /name command to Minecraft, which players can use to set a prefix, suffix, or nickname.
GNU Lesser General Public License v3.0
2 stars 1 forks source link

[BUG] Prefix in command auto fill #2

Closed SkyLord-103 closed 4 months ago

SkyLord-103 commented 4 months ago

When the mod is active the prefixes work as intended but the prefixes appear in command auto fills breaking the player's actual name. If the name is too long it can cut off parts as well.

image

I'm running a 1.20.4 fabric server, loader version 0.15.11

I'm unsure if this is unintended behavior or not. Thanks!

eclipseisoffline commented 4 months ago

Hm, that's not supposed to happen. Can you send the mod list on your server?

Does the issue happen with all commands, or only specific ones?

SkyLord-103 commented 4 months ago

It seems a lot of commands use the prefix, mostly vanilla commands. Except for Banhammer's commands.

These are the mods that are currently being used https://modrinth.com/collection/LzS7b3jH Please let me know if you need the list in some other format

I tested these commands

Voice chat
/voicechat test

Vanilla commands
/tp
/teleport
/tellraw
/tell
/kill
/xp set
/damage
/spectate
/minecraft:ban
/minecraft:kick

Essential Commands
/home tp_other
/extinguish, My user name appears twice one with the prefix and one without
eclipseisoffline commented 4 months ago

Thank you! This should definitely not happen. I'm pretty busy tomorrow but I will do some testing on Friday and I'll try to implement a fix during the weekend.

SkyLord-103 commented 4 months ago

Awesome, enjoy your weekend!

eclipseisoffline commented 4 months ago

Hm, I downloaded your mods and ran them on a local testing server (Fabric 0.15.11 on Minecraft 1.20.4) and was unable to reproduce the issue. It's possible that a mod on your Minecraft client is causing the issue.

Did you try joining your server with only the mods necessary to join and no other, and seeing if the issue still exists? If it doesn't, which mods did you remove that fixed the issue?

SkyLord-103 commented 4 months ago

I just tried joining with a vanilla client and a no mod fabric client and I still have the issue. Strange. I will try and update the server's mods and test again myself and with a friend.

If nothing works on my side and since you aren't able to replicate the issue I may just have to live with it. Thanks for the help!

eclipseisoffline commented 4 months ago

Could you possibly send over a ZIP file of your server mods folder? Maybe I'm able to reproduce it that way

SkyLord-103 commented 4 months ago

Apologies for the late reply. I tested with a friend and the issue still appears which sucks. And sure, here are the mods and config folders

eclipseisoffline commented 4 months ago

Thank you! It's unfortunate that the issue remains. I'll try to reproduce it using these options tomorrow and hopefully find the cause of the issue.

eclipseisoffline commented 4 months ago

Seems like access to the drive link you sent is denied

SkyLord-103 commented 4 months ago

Oops I thought I made it open Try this one

eclipseisoffline commented 4 months ago

Works, thank you

eclipseisoffline commented 4 months ago

Hi, I have reproduced the issue and identified what causes it! In your essential commands configuration, you have the nickname_above_head option enabled. Simply disabling this option should fix the issue.

If you're interested in a technical explanation, the nickname_above_head option is implemented by sending the nicknames of players as their literal player names to the client. This causes the client to show the nicknames above the player heads as if they were their literal names, but also causes the client to list these nicknames in the player suggestions in commands, since the client thinks these are the real player names.

There might be a fix available, but it probably won't be an easy one to implement. It's easier to just disable the option, since it doesn't cause a huge inconvenience. The issue has already been reported on the essential commands repo (here).

SkyLord-103 commented 4 months ago

Thats great!! huh darn I didn't know thats how names are transfered lol I'll update essentials when I have access to the server and then celebrate! Thank you very much for the help!