eclipselabs / passerelle

Passerelle, an actor-based process engine based on Ptolemy II
5 stars 3 forks source link

New composites does not appear immediately in the palette, only after restarting the workbench #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. In the (atcor) palette, create a new composite by right-clicking on 
"Composites" and choose "create new composite"
2. In the dialog box type the name of a new composite
3. Click on "Finish"

What is the expected output? What do you see instead?

The expected output is a new composite in the list of composites.
The observed output is no change. Only after restarting the workbench/eclipse 
the new composite becomes visible.

What version of the product are you using? On what operating system?

Latest trunk SVN as of today (2011-11-21). Observed both on Linux and Windows.

Please provide any additional information below.

This problem was not observed in the DAWB fork of the isencia bundles.

Thanks in advance for looking into this!

Original issue reported on code.google.com by s.olof.svensson@gmail.com on 21 Nov 2011 at 10:01

GoogleCodeExporter commented 9 years ago
assigned to Koen

Original comment by erwin...@gmail.com on 21 Nov 2011 at 11:04

GoogleCodeExporter commented 9 years ago
I'm not able to reproduce this issue. You are using follwoing plugins : 

-https://svn.codespot.com/a/eclipselabs.org/passerelle/trunk/passerelle-eclipse-
workbench/com.isencia.passerelle.workbench
-https://svn.codespot.com/a/eclipselabs.org/passerelle/trunk/passerelle-eclipse-
workbench/com.isencia.passerelle.workbench.model
-https://svn.codespot.com/a/eclipselabs.org/passerelle/trunk/passerelle-eclipse-
workbench/com.isencia.passerelle.workbench.model.editor.ui
-https://svn.codespot.com/a/eclipselabs.org/passerelle/trunk/passerelle-eclipse-
workbench/com.isencia.passerelle.workbench.model.model.ui
-https://svn.codespot.com/a/eclipselabs.org/passerelle/trunk/passerelle-eclipse-
workbench/com.isencia.passerelle.workbench.util

I tested this using our target and dawb target. In both cases it seems to work.

How did you launch your ide? 
Do you have the same issue using a new workspace? Maybe there is interference 
from the existing submodels in workspace.

Original comment by kheuni...@gmail.com on 21 Nov 2011 at 11:39

GoogleCodeExporter commented 9 years ago
I checked it also, both in plain Passerelle workbench and in DAWB launched from 
my DAWB workspace (up-2-date with status of DAWB of last friday).

In both cases the Passerelle palette shows the composite directly.

BUt, strange thing : In DAWB there are 2 palettes!! And the "other" one is 
indeed not refreshing.

You'll see them in the attached screen shot.
The palette on the left is the "real" one, as we're also getting it in the 
basic Passerelle workbench. THe one on the right is some zombie from ????

I then deleted the workspace for the dawb debug launcher and retried.
Then the Passerelle palette is not even shown, only the zombie one is present 
by default.

So it should be something with DAWB perspective definitions that are wrong.

Original comment by erwin...@gmail.com on 21 Nov 2011 at 1:04

Attachments:

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Your two palette problem is just an artefact of recent addtions. Simply right 
click and reset the 'workflow' perspective in dawb. Users will not see this.

Original comment by matthew....@gmail.com on 21 Nov 2011 at 2:00

GoogleCodeExporter commented 9 years ago
Hey Matthew,

I've attached 2 wink-screencasts. 
I still need to learn how to use this tool, but I hope they make things more 
clear.

The Passerelle-one just has one Palette view which works fine.

The DAWB workbench, after a reset of a perspective, contains some kind of 
zombie palette that works almost completely, except for showing the new 
composite.

THe "real" palette is available in the "view list" and can be opened manually, 
and works fine...

Any clue what could be the cause of this?

Original comment by erwin...@gmail.com on 21 Nov 2011 at 6:04

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for looking into this! I have succeeded in starting the Passerelle 
workspace and indeed the palette is working fine there.

On the other hand I have not been able to reproduce the double palette as 
reported by Erwin: I just get one palette on the right side which has the 
problem as reported above.

I'm using DAWB/Passerelle trunk as of this morning with the following isencia 
bundles:

com.isencia.passerelle.actor (324)
com.isencia.passerelle.commons (309)
com.isencia.passerelle.commons.ume (123)
com.isencia.passerelle.engine (325)
com.isencia.passerelle.workbench.model (338)
com.isencia.passerelle.workbench.model.editor.ui (339)
com.isencia.passerelle.workbench.model.ui (338)
com.isencia.passerelle.workbench.util (339)

I'm starting DAWB with an empty workspace.

Erwin, could you please verify that you still get double palettes with the 
latest DAWB trunk?

Original comment by s.olof.svensson@gmail.com on 22 Nov 2011 at 8:43

GoogleCodeExporter commented 9 years ago
Hi Olof,

I synched my DAWB workspace, taking all current trunk projects, features, 
target etc from the DAWB repository and also with the Passerelle bundles from 
our trunk.
All compiles fine.

I found DAWB has still the same issue as I described above. Can you pls 
download my attached zip in the previous comment, extract it and play the 
screen casts I added? You will then be able to see what I mean. You just need 
to open the hmtl files to launch the screen casts.

Some more details :
Launching the updated DAWB gave problems with conflicting linkages on SLF4J.
It seems it is not only present in the DAWB target, as a separate SLF4J bundle, 
but also in a JAR inside uk.ac.gda.libs. 
This bundle exports the SLF4J packages as well, but without version info. 
The "real" SLF4J bundle exports the packages with version info 1.5.6.
Which leads to unpredictable SLF4J class loading conflicts, unless all client 
bundles require version e.g. 1.5.0 or more.
THere are plenty of bundles in DAWB that do not specify the SLF4J version info, 
so each gets linked arbitrarily to one of the SLF4J providers.

You can check this on your side by adding the argument " -console" in your 
launch configuration, e.g. right after the "  -consoleLog" that is already in 
there.
And then, after launching DAWB, do "packages org.slf4j" on the osgi console 
prompt.
You will see it has 2 provider bundles i.o. 1, and it also shows which DAWB 
bundles link to which SLF4J provider.

I adapted any dependency on SLF4j in Passerelle bundles to explicitly put a 
version constraint on at least 1.5.0 and committed the changes. So my bundle 
versions are now sometimes a bit more recent than yours, but no code change.

To reiterate : DAWB somehow opens by default a zombie/crippled Palette view.
It has the same icon as the DAWB Data view. In fact, as you will see in the 
screencast, it seems to be "substituted" for the Data view somehow.
This zombie Palette is not present in our Passerelle perspective.

When you go to the menu Window > Show View > Other > Palette View, you will 
notice the "real" Palette there with the right icon to identify it.
This one works perfectly, and is the one we include in our Passerelle 
perspective.

Original comment by erwin...@gmail.com on 23 Nov 2011 at 11:33

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Based on above diagnosis, this does not seem to be a Passerelle-related issue.

Closing this issue without fix.

Original comment by erwin...@gmail.com on 7 Dec 2011 at 7:38

GoogleCodeExporter commented 9 years ago
Hi Erwin,

Thanks for looking into this. I agree that it wasn't a Passarelle-related 
issue. In the latest SVN/GIT version of DAWB which I tried today the problem 
has fortunately gone away.

Olof

Original comment by s.olof.svensson@gmail.com on 8 Dec 2011 at 2:19