search

eclipselabs / passerelle

Passerelle, an actor-based process engine based on Ptolemy II
5 stars 3 forks source link

Bug in opening submodels #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I just found a bug in the code opening submodels: instead of using className 
(i.e. the name of the submodel moml file) the name of the submodel was used for 
opening the file:

@@ -172,11 +172,11 @@ public class CompositeActorEditPart extends 
ContainerEditPart implements IActorN

       public void mouseDoubleClicked(MouseEvent e) {
         TypedCompositeActor model = (TypedCompositeActor) getModel();
         if (model instanceof Flow && Activator.getDefault().getPreferenceStore().getBoolean(PasserellePreferencePage.SUBMODEL_DRILLDOWN)) {
           try {
-            EditSubmodelAction.openFlowEditor(model.getName());
+            EditSubmodelAction.openFlowEditor(model.getClassName());
           } catch (Exception e1) {
             EclipseUtils.logError(e1, "Open submodel failed", Status.ERROR);
           }

         } else {

I'll commit this patch soon.

Original issue reported on code.google.com by s.olof.svensson@gmail.com on 12 Apr 2013 at 1:44

GoogleCodeExporter commented 9 years ago 
Patch committed:

http://code.google.com/a/eclipselabs.org/p/passerelle/source/detail?r=1510

I also forwarded a fix by Baha in DAWN:

http://code.google.com/a/eclipselabs.org/p/passerelle/source/detail?r=1511

Original comment by s.olof.svensson@gmail.com on 12 Apr 2013 at 1:59