search

eclipselabs / passerelle

Passerelle, an actor-based process engine based on Ptolemy II
5 stars 3 forks source link

Modifications of ActorEditPart #65

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
On 08/01/2014 09:53, Erwin de Ley wrote:

I would prefer to not touch the old actor hierarchy, as the v5 actor API no 
longer really needs all those intermediate abstract actor classes.

On the other hand, it is indeed useful to be able to distinguish port colours 
and probably also actor background colours.
But I think this could be done in the workbench code, by adapting the 
ActorEditPart.

I propose to add the code in there to find input ports named "trigger", and to 
check if the actor has no "normal" input or output ports and then apply the 
matching colours. I.e. merge the code for the customized actor edit parts in 
there.

Original issue reported on code.google.com by s.olof.svensson@gmail.com on 8 Jan 2014 at 12:30

GoogleCodeExporter commented 9 years ago 
As extra info : this is related to actors based on actor v5 that are not 
inheriting from "old-style" Source or Sink etc.

The colouring of source and sink actors (and a source's trigger input port) 
would need to be reproduced for these v5-based actors. And this can be done by 
some small changes in ActorEditPart.

Change has been committed after some tests in a vanilla Passerelle workbench.

Original comment by erwin...@gmail.com on 9 Jan 2014 at 10:06