search

eclipsesource / graphical-lsp

Graphical language server platform for building web-based diagram editors
https://www.eclipse.org/glsp
Eclipse Public License 2.0
36 stars 8 forks source link

Resolve #214 Keep validation markers for model reload #223

Closed tanjaem closed 5 years ago

tortmayr commented 5 years ago

Thanks! Seems to work in most cases, but I found a bug where error markers for resolved problems are not cleared on (re)validation: no_marker_dis

Why do we need to reapply old markers before an update? Doesn't SetModelAction.markers contain the entire marker information anyways? Correct me If I'm wrong, but wouldn't it be sufficient to implement the current SetModelMarkersCommand (i.e the version on master) as FeedbackCommand and dispatch the corresponding action in the tool-palette via FeedbackActionDispatcher?

tanjaem commented 5 years ago

@tortmayr, thanks for your review and feedback! I hope my new changes fix the problems you encountered!