Update/Refactor server packages

eclipsesource / graphical-lsp

Graphical language server platform for building web-based diagram editors

https://www.eclipse.org/glsp

Eclipse Public License 2.0

36 stars 8 forks source link

Update/Refactor server packages #227

Closed tortmayr closed 5 years ago

tortmayr commented 5 years ago

Cleanup and major refactorings of the GLSP server API. Also incorporates some of the relevant latest changes from https://github.com/eclipse/sprotty-server.

Summary:

Introduce DiagramManager API that allows the handling of different diagram types/kinds with one server component.
Improve and refactor the ModelState API. (In future changes this API shall be extended to support ModelStates for both the graphical and the semantic model)
Refactor all suitable methods of SModelIndex to make use of the Optional API
Implement support for automatic/manual server layouting (migrated from eclipse/sprotty-server).
Refactor the Java action definitions to use collections over arrays (where applicable)
Fixed a bug that occurred when deleting multiple selected elements.
Refactor and clean up the default operation handlers

planger commented 5 years ago

In future changes this API shall be extended to support ModelStates for both the graphical and the semantic model

I think this is an interesting point for discussion, ie whether we actually want to make GLSP aware of a model state at all rather than just letting it manage a graphical model state. I think it has some advantages of keeping it agnostic of how the graphical model actually has been constructed (from a semantic model + notation or anything else?) and put an own component before GLSP that actually constructs the model and translates changes GLSP applied to the graphical model to the respective semantic model and notation model etc. What do you think?

CamilleLetavernier commented 5 years ago

According to my experiments so far, there is indeed no need for GLSP to be aware of the separation between semantics and notation (Although each specific GLSP Server Implementation should be able to translate from/to a Semantic + Notation <-> GSLP model graph)

This is also the case for desktop diagram applications: the UI part (e.g. GEF) only cares about presentation & interactions, and doesn't need to know anything about the separation between Notation and Semantics (Specific to GMF)