search

eclipsesource / graphical-lsp

Graphical language server platform for building web-based diagram editors
https://www.eclipse.org/glsp
Eclipse Public License 2.0
36 stars 8 forks source link

ModelFactory.loadModel should return optional #282

Closed tortmayr closed 4 years ago

tortmayr commented 5 years ago

Currently the default implementation of theRequestModelHandler does not null-check the result of modelFactory.loadModel(). This leads to a lot of potential issues (e.g. The model result could be null because no (or an invalid) sourceURI was passed. Preferably this should be refactored to the Optional API.