eclipsesource / graphical-lsp

Graphical language server platform for building web-based diagram editors
https://www.eclipse.org/glsp
Eclipse Public License 2.0
36 stars 8 forks source link

Fix #311 Implement GLSPConfigurator for websocket connections #312

Closed tortmayr closed 5 years ago

tortmayr commented 5 years ago

The P2 counterpart of glsp-server-websocke was not working because javax.websocket relies on some services that should be provided via ServiceLoader. This is not always the case when using the plugin in an OSGI context.

This change introduces a GLSPConfigurator for ServerEndpoints that has a fallback option if no service is provided via ServiceLoader.

(Integrated and tested locally in the glsp-p2 repository)