search

eclipsesource / graphical-lsp

Graphical language server platform for building web-based diagram editors
https://www.eclipse.org/glsp
Eclipse Public License 2.0
36 stars 8 forks source link

Use enums for String constants #362

Closed tortmayr closed 4 years ago

tortmayr commented 4 years ago

In the current implementation of the Graph API (GModel) it's unclear what values are allowed for certain String properties like "layout", "hAlign", "edgePlacement" etc.

We should probably create Enums with the default types (derived from the sprotty client implementation) for this.

tortmayr commented 4 years ago

as discussed offline: Enums are a little bit restrictive for this case. Probably better to provide the possible values as string constants.