search

eclipsesource / graphical-lsp

Graphical language server platform for building web-based diagram editors
https://www.eclipse.org/glsp
Eclipse Public License 2.0
36 stars 8 forks source link

Fix id generation for modelserver example #382

Closed tortmayr closed 4 years ago

tortmayr commented 4 years ago

Previously all GModel-ids would be regenerated after a server update. This caused a weird flicker animation on the client side. The GModelIdAdapter can be used to attach a (randomly generated) id to an EObject. Also fixed an issue which triggered a full-Update of the modelserver after a ChangeBoundsAction

tortmayr commented 4 years ago

Oh yes, you are right. I completely forgot to add the adapter to newly created elements

tortmayr commented 4 years ago

Actually the delete issue is not directly related to this change. It's a faulty implementation of the DeleteOperationHandler. All files are deleted locally (semantic & diagram) and then a full update of the model server is triggered.

I have pushed a temporary fix for this to support the local remove. The proper integration of the delete-operation with the modelserver will be done in a follow-up PR

planger commented 4 years ago

@tortmayr Thanks for the fix, the change looks good. Can you please just resolve the conflicts, I'll then do another test and then we can merge it. Thanks!