search

eclipsesource / jshint-eclipse

JSHint integration for the Eclipse IDE
http://github.eclipsesource.com/jshint-eclipse/
146 stars 31 forks source link

Fix licenseURL #113

Closed scop closed 8 years ago

ralfstx commented 8 years ago

Could you explain this change? The licenseURL points to a local file, which is present. This seems to be common practice. Any pointer why you consider it broken?

scop commented 8 years ago

The point is that it does not currently point to a local file that is present, it points to www.eclipse.org/legal/epl-v10.html -- I don't think that exists, whereas what I corrected it to, epl-v10.html does exist in the same dir as features.properties. Another choice I suppose would be to change it to http://www.eclipse.org/legal/epl-v10.html but that doesn't seem necessary because a local copy is present.

What prompted me to make this change is that when I today got the upgrade of jshint-eclipse, my Eclipse showed me the license to agree to for the upgrade, and the license textarea contained just the single word license, so no license text. I have no idea if fixing the licenseURL would fix it, but it seems like it does need fixing.

ralfstx commented 8 years ago

Sorry, I mixed up incoming and outgoing in the change. Makes perfect sense now. Thank you!