Implement Categorization palette tool

eclipsesource / jsonforms-editor

Visual Editor for JSON Schema and JSON Forms Ui Schema

https://jsonforms-editor.netlify.app/

Other

79 stars 38 forks source link

Implement Categorization palette tool #121

Closed kchobantonov closed 3 years ago

kchobantonov commented 3 years ago

Provided ability to create Categorization and Category elements using palette tool. Allow switching and modifying a specific Category (tab) element when in Editor mode.

CLAassistant commented 3 years ago

All committers have signed the CLA.

eneufeld commented 3 years ago

Hi @kchobantonov , thank you very much for the contribution. What do you think about moving the button to add a new tab into the tab list? I found this example https://codesandbox.io/s/button-in-tabs-xppyr

kchobantonov commented 3 years ago

yes nice suggestion - let me update the pull request with that change

AlexandraBuzila commented 3 years ago

Thank you for the updated changes, they look good! I have one more nit-pick (sorry) and then we can merge the PR: the selection in the Categorization is now cleared when tabs are deleted. The selection should move to the previous tab in the list, like it did in your original version.

kchobantonov commented 3 years ago

reselecting another tab when the currently selected tab was deleted is now part of this PR

AlexandraBuzila commented 3 years ago

It seems like one of the users (@kchobantonov-vertiv) that was used in some commits did not sign the CLA. Could you sign the agreement with that account as well, please? Or, even better, just squash the commits and push with the user that has a signed CLA. Unfortunately we cannot merge the changes without a signed agreement.

https://cla-assistant.io/eclipsesource/jsonforms-editor?pullRequest=121