search

eclipsesource / jsonforms-react-seed

React-based JSON Forms Seed App
https://jsonforms-react-seed.netlify.app
138 stars 141 forks source link

Use tss in place of the deprecated @mui/styles #116

Open garronej opened 7 months ago

garronej commented 7 months ago

Hello @edgarmueller,

@mui/styles (makeStyles) is deprecated in @mui/material v5. Ref.

The recommended solution with minimal DIFF is to use tss-react instead. Ref.

Thank you for this great library.

Best

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

sdirix commented 7 months ago

Hi @garronej, thanks for the contribution!

The deprecation notice mentions MUI System. Shouldn't we use that instead of another third party library?

garronej commented 7 months ago

Well, tss-react is a drop-in replacement.
Besides, I find the MUI styling system cumbersome. It requires all styles to be inline or splits the component into different styled blocks, similar to styled-components.
TSS is well-established, as evidenced by its large number of downloads.

However, I'm biased since I am the author of TSS, so naturally, I believe it to be the better option 😄

Feel free to not merge; I understand your point and will take no offence.